Skip to content

Remove tmp and @types/tmp dependencies#7192

Merged
ryancbahan merged 1 commit intomainfrom
04-03-remove-tmp-package
Apr 7, 2026
Merged

Remove tmp and @types/tmp dependencies#7192
ryancbahan merged 1 commit intomainfrom
04-03-remove-tmp-package

Conversation

@ryancbahan
Copy link
Copy Markdown
Contributor

@ryancbahan ryancbahan commented Apr 3, 2026

Summary

  • Remove tmp and @types/tmp from root devDependencies

@ryancbahan ryancbahan marked this pull request as ready for review April 3, 2026 22:17
@ryancbahan ryancbahan requested a review from a team as a code owner April 3, 2026 22:17
Replace the single usage in bin/update-bugsnag.js with Node's built-in
fs.mkdtemp + cleanup in a finally block. Remove both packages from
root devDependencies.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you run the script?

Copy link
Copy Markdown
Contributor Author

@ryancbahan ryancbahan Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Works as intended

ryan@Mac cli % node bin/update-bugsnag.js cli
Preparing @shopify/cli
Copying to temporary directory
Uploading to Bugsnag
Cleaning sourcemaps from @shopify/cli
[bugsnag-build-reporter] no source control info found (looked in package.json, .git, .hg)
[bugsnag-build-reporter] sending {
  apiKey: '******5e0fae',
  appVersion: '3.93.0',
  builderName: 'ryan',
  buildTool: 'bugsnag-build-reporter',
}
[bugsnag-build-reporter] build info sent
Build reported!
ryan@Mac cli %

@ryancbahan ryancbahan added this pull request to the merge queue Apr 7, 2026
Merged via the queue into main with commit 0a00e73 Apr 7, 2026
25 checks passed
@ryancbahan ryancbahan deleted the 04-03-remove-tmp-package branch April 7, 2026 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants