Remove camelcase-keys, replace with inline utility#7194
Remove camelcase-keys, replace with inline utility#7194ryancbahan wants to merge 1 commit intographite-base/7194from
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Add a local camelcase-keys.ts with parity behavior: snake_case/kebab-case to camelCase key conversion, deep recursion, leading underscore stripping, ALL_CAPS handling, and Date/non-plain-object preservation. Includes 16 parity tests. Update 4 call sites in app-logs to use the local module. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ryancbahan
force-pushed
the
04-03-04-03-remove-camelcase-keys
branch
from
1a01cd0 to
ffadb6c
Compare
|
We detected some changes at Caution DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release. |
| /** | ||
| * Converts a string from snake_case or kebab-case to camelCase. | ||
| */ | ||
| function toCamelCase(str: string): string { |
There was a problem hiding this comment.
We already have a similar function in cli-kit. If you need anything else, I think we should add it to that file.
There was a problem hiding this comment.
Happy to follow up on this, but i think we should prioritize shipping this to support the supply chain remediation project
There was a problem hiding this comment.
Well, camelcase-keys is pinned to a specific version that we have been using for a long time, so it doesn't look urgent.
There was a problem hiding this comment.
I agree with Gonzalo here, we can use the one from cli-kit. No need to add 2 new files with 100+ changes for something that already exists :thinking_face:
An agent can quickly update this PR to use the camelize function from cli-kit, I don't think there is that much urgency to remove this dependency that prevents us to doing it the right way!
ryancbahan
changed the base branch from
04-03-04-03-remove-ansi-colors
to
graphite-base/7194
3 participants
Summary
camelcase-keys.ts(~40 lines) inapp-logs/with parity behavior to the npm packagepoll-app-logs.ts,utils.ts, and their test files)camelcase-keysfrompackages/app/package.jsonTest plan