Remove network-interfaces, use os.networkInterfaces() directly#7195
Remove network-interfaces, use os.networkInterfaces() directly#7195ryancbahan wants to merge 1 commit into04-03-04-03-remove-camelcase-keysfrom
Conversation
The single usage was a validation check (ni.fromIp) that verifies an IP exists on a local internal IPv4 interface. Replaced with a ~10 line inline helper using Node's os.networkInterfaces(). Also removed the hand-written type declaration file. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
We detected some changes at Caution DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release. |
There was a problem hiding this comment.
We are vendoring this from https://github.com/Shopify/dev_server, I think we should remove the dependency from there and then update this code.

Summary
ni.fromIp()call indev-server-2024.tswith an inlineassertIpOnLocalInterface()helper using Node'sos.networkInterfaces()network-interfacesfrom cli-kit dependencies and delete the hand-written.d.tstype declaration