Skip to content

Remove ansi-colors, replace with lightweight inline utility#7193

Open
ryancbahan wants to merge 2 commits into04-03-remove-tmp-packagefrom
04-03-04-03-remove-ansi-colors
Open

Remove ansi-colors, replace with lightweight inline utility#7193
ryancbahan wants to merge 2 commits into04-03-remove-tmp-packagefrom
04-03-04-03-remove-ansi-colors

Conversation

@ryancbahan
Copy link
Copy Markdown
Contributor

@ryancbahan ryancbahan commented Apr 3, 2026

Summary

  • Remove ansi-colors from root devDependencies

Copy link
Copy Markdown
Contributor Author

ryancbahan commented Apr 3, 2026

@ryancbahan ryancbahan marked this pull request as ready for review April 3, 2026 22:17
@ryancbahan ryancbahan requested a review from a team as a code owner April 3, 2026 22:17
@ryancbahan ryancbahan force-pushed the 04-03-04-03-remove-ansi-colors branch from 7e68060 to 6598c1f Compare April 3, 2026 22:18
@ryancbahan ryancbahan force-pushed the 04-03-remove-tmp-package branch from 3c8e8a8 to 19a03ac Compare April 3, 2026 22:18
@ryancbahan ryancbahan force-pushed the 04-03-04-03-remove-ansi-colors branch from 6598c1f to e99cba9 Compare April 3, 2026 22:20
@ryancbahan ryancbahan changed the title Remove unused ansi-colors dependency Remove ansi-colors, replace with lightweight inline utility Apr 3, 2026
Replace the 3 call sites with inline ANSI escape sequences:
- bin/create-homebrew-pr.js: green + bold
- workspace/src/lint.js: green.bold, red.bold, bold, dim
- workspace/src/utils/log.js: green.bold, gray

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Contributor

@gonzaloriestra gonzaloriestra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you checked that the scripts keep showing the same styles?

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 6, 2026

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/public/node/monorail.d.ts
@@ -66,10 +66,6 @@ export interface Schemas {
             cmd_app_linked_config_uses_cli_managed_urls?: Optional<boolean>;
             cmd_app_warning_api_key_deprecation_displayed?: Optional<boolean>;
             cmd_app_deployment_mode?: Optional<string>;
-            cmd_app_validate_json?: Optional<boolean>;
-            cmd_app_validate_valid?: Optional<boolean>;
-            cmd_app_validate_issue_count?: Optional<number>;
-            cmd_app_validate_file_count?: Optional<number>;
             cmd_dev_tunnel_type?: Optional<string>;
             cmd_dev_tunnel_custom_hash?: Optional<string>;
             cmd_dev_urls_updated?: Optional<boolean>;

Copy link
Copy Markdown
Contributor Author

Have you checked that the scripts keep showing the same styles?

​Yes, I ran the type diff. Screenshot 2026-04-06 at 4.01.09 PM.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants